Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): fix missing closing bracket #4837

Merged
merged 2 commits into from
May 24, 2021
Merged

docs(v2): fix missing closing bracket #4837

merged 2 commits into from
May 24, 2021

Conversation

pmqueiroz
Copy link
Contributor

Motivation

Improve API documentation

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Minimal changes no need to deep tests

Related PRs

N/A

@facebook-github-bot
Copy link
Contributor

Hi @pmqueiroz!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented May 23, 2021

@github-actions
Copy link

github-actions bot commented May 23, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4837--docusaurus-2.netlify.app/

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 23, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label May 24, 2021
@lex111 lex111 changed the title fix: missing closing bracket docs(v2): fix missing closing bracket May 24, 2021
@lex111 lex111 merged commit 4db8ded into facebook:master May 24, 2021
@lex111
Copy link
Contributor

lex111 commented May 24, 2021

@pmqueiroz thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants