-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: optimize showcase images #4901
Conversation
✔️ [V1] 🔨 Explore the source changes: c389735 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60b90d5468a7280008dff54f 😎 Browse the preview: https://deploy-preview-4901--docusaurus-1.netlify.app |
✔️ [V2] 🔨 Explore the source changes: c389735 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60b90d549b6588000761f85c 😎 Browse the preview: https://deploy-preview-4901--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4901--docusaurus-2.netlify.app/ |
Size Change: 0 B Total Size: 621 kB ℹ️ View Unchanged
|
Thanks, LGTM 👍 Also wanted to do that. Maybe you could add a node script so that we could run this compression again from time to time? |
Used this package for this, and "optimizt `find src/data/showcase -type f -name '*.png'`" command in particular. Perhaps it makes sense to create separate GitHub action that will automatically optimize images in new PRs? |
Thanks, just keeping the command in git may be enough for now, we won't run that often, but if you find a way to automate this, why not as long as it's not run on every PR |
Motivation
Reducing size of sites screenshots in the showcase, which potentially should speed up build site / page load and just facilitate work for ideal-image plugin.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)