Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: optimize showcase images #4901

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 3, 2021

Motivation

Reducing size of sites screenshots in the showcase, which potentially should speed up build site / page load and just facilitate work for ideal-image plugin.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jun 3, 2021
@lex111 lex111 requested a review from slorber as a code owner June 3, 2021 17:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 3, 2021
@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ [V1]

🔨 Explore the source changes: c389735

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60b90d5468a7280008dff54f

😎 Browse the preview: https://deploy-preview-4901--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Jun 3, 2021

✔️ [V2]

🔨 Explore the source changes: c389735

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60b90d549b6588000761f85c

😎 Browse the preview: https://deploy-preview-4901--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4901--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jun 3, 2021

Size Change: 0 B

Total Size: 621 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 88.3 kB 0 B
website/build/assets/js/main.********.js 443 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27.1 kB 0 B

compressed-size-action

@slorber
Copy link
Collaborator

slorber commented Jun 3, 2021

Thanks, LGTM 👍

Also wanted to do that. Maybe you could add a node script so that we could run this compression again from time to time?

@slorber slorber merged commit 0cfdda8 into master Jun 3, 2021
@lex111
Copy link
Contributor Author

lex111 commented Jun 3, 2021

Used this package for this, and "optimizt `find src/data/showcase -type f -name '*.png'`" command in particular. Perhaps it makes sense to create separate GitHub action that will automatically optimize images in new PRs?

@slorber
Copy link
Collaborator

slorber commented Jun 9, 2021

Thanks, just keeping the command in git may be enough for now, we won't run that often, but if you find a way to automate this, why not as long as it's not run on every PR

@slorber slorber deleted the lex111/optimize-showcase-images branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants