Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): remove type attribute from link and script tags #4907

Merged
merged 3 commits into from
Jun 9, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 4, 2021

Motivation

These are completely unnecessary attributes that are actually already being removed by the minifier (terser), so we can remove them from the codebase itself.

The default type for resources given by the stylesheet keyword is "text/css" (see w3.org/TR/html5/links.html#link-type-stylesheet)
For scripts, default type is "text/javascript" (see http://www.w3.org/TR/html5/scripting-1.html#attr-script-type)

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jun 4, 2021
@lex111 lex111 requested a review from slorber as a code owner June 4, 2021 13:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 4, 2021
Copy link
Collaborator

@slorber slorber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ [V1]

🔨 Explore the source changes: a0e0d9b

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-1/deploys/60c0a89e5a932f000742345b

😎 Browse the preview: https://deploy-preview-4907--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Jun 9, 2021

✔️ [V2]

🔨 Explore the source changes: a0e0d9b

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c0a89e21a9a50007d944d0

😎 Browse the preview: https://deploy-preview-4907--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 64
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4907--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Size Change: -897 B (0%)

Total Size: 620 kB

Filename Size Change
website/build/assets/css/styles.********.css 87.7 kB -622 B (-1%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB -160 B (0%)
website/build/index.html 27 kB -99 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/js/main.********.js 443 kB -16 B (0%)
website/build/docs/introduction/index.html 235 B 0 B

compressed-size-action

@slorber slorber merged commit 55e9bd8 into master Jun 9, 2021
@slorber slorber deleted the lex111/remove-type-script-link branch August 17, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants