Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: lockfile cleanup #4944

Merged
merged 2 commits into from
Jun 10, 2021
Merged

chore: lockfile cleanup #4944

merged 2 commits into from
Jun 10, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 10, 2021

Motivation

Fix unstable lockfile after v1 cleanuup PR + upgrade deps

Had an ESLint issue (FB header in CLI with shebang: Stuk/eslint-plugin-header#39). Disabled in 3 places, we'll see if we can re-enable this later

Test Plan

tests

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Jun 10, 2021
@slorber slorber requested a review from lex111 as a code owner June 10, 2021 13:55
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 10, 2021
@netlify
Copy link

netlify bot commented Jun 10, 2021

✔️ [V2]

🔨 Explore the source changes: db8c8de

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c219c49cabea00088a9004

😎 Browse the preview: https://deploy-preview-4944--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 51
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4944--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +663 B (0%)

Total Size: 621 kB

Filename Size Change
website/build/assets/js/main.********.js 444 kB +663 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.8 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.1 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27 kB 0 B

compressed-size-action

@slorber slorber merged commit aff848e into master Jun 10, 2021
@slorber slorber deleted the slorber/cleanup-lockfile branch August 17, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants