Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): improve semantic blog sidebar markup #4961

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Jun 14, 2021

Motivation

Does the same thing as #4940, but for the blog sidebar.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jun 14, 2021
@lex111 lex111 requested a review from slorber as a code owner June 14, 2021 07:25
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 14, 2021
@netlify
Copy link

netlify bot commented Jun 14, 2021

✔️ [V2]

🔨 Explore the source changes: 70c9c88

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c70483fd9d30000880eaae

😎 Browse the preview: https://deploy-preview-4961--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 62
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4961--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: +46 B (0%)

Total Size: 621 kB

Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 62.2 kB +46 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.8 kB 0 B
website/build/assets/js/main.********.js 444 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 27 kB 0 B

compressed-size-action

@slorber slorber merged commit 8629fbd into master Jun 14, 2021
@slorber
Copy link
Collaborator

slorber commented Jun 14, 2021

LGTM thanks

@slorber slorber deleted the lex111/sidebar-blog-sem branch August 17, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants