Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): replace diff codeblocks with line highlight #4973

Merged
merged 2 commits into from
Jun 16, 2021

Conversation

Josh-Cena
Copy link
Collaborator

Motivation

Resolve #4698. There are some diff code blocks with only + and no -. In this case using line highlight equally makes sense, with the additional merits of:

  1. Not generating "confusing code" when using copy button;
  2. Leverages syntax highlight to make the code block more visually appealing.

For the rest of the code blocks that have - as well, I kept them as-is.

Have you read the Contributing Guidelines on pull requests?

Yep

Signed-off-by: Josh-Cena <sidachen2003@gmail.com>
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 15, 2021
@netlify
Copy link

netlify bot commented Jun 15, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 51b0836

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60c937d780cd5c00090cbe64

😎 Browse the preview: https://deploy-preview-4973--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jun 15, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 69
🟢 Accessibility 97
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4973--docusaurus-2.netlify.app/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jun 16, 2021
@slorber
Copy link
Collaborator

slorber commented Jun 16, 2021

Thanks 👍

@slorber slorber merged commit af3640d into facebook:master Jun 16, 2021
@Josh-Cena Josh-Cena deleted the replace-diff branch June 16, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy control in the getting-started tutorial copies confusing code
3 participants