Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix swizzle readComponent #5095

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jun 30, 2021

Motivation

Bad regex prevent usage of npm run swizzle @docusaurus/theme-classic when running outside our Docusaurus monorepo (when using node_modules)

Quick fix #5083

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

none: the swizzle code is not testable and hard to maintain, all this should be rewritten someday

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jun 30, 2021
@slorber slorber requested a review from lex111 as a code owner June 30, 2021 10:14
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 30, 2021
@netlify
Copy link

netlify bot commented Jun 30, 2021

✔️ [V2]

🔨 Explore the source changes: 7f0101e

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60dc4423f21fcf0008490bdc

😎 Browse the preview: https://deploy-preview-5095--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5095--docusaurus-2.netlify.app/

@slorber slorber merged commit ab3821c into master Jun 30, 2021
@github-actions
Copy link

Size Change: 0 B

Total Size: 605 kB

ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 87.7 kB
website/build/assets/js/main.********.js 415 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.7 kB
website/build/docs/introduction/index.html 235 B
website/build/index.html 33.4 kB

compressed-size-action

@yangshun yangshun deleted the slorber/fix-swizzle-readComponent branch August 7, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running Swizzle for all doesn't work
2 participants