fix(v2): fix redirect plugin when trailingSlash=false for .html extension #5102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 09fcb9b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60dc886c11cd65000890efca 😎 Browse the preview: https://deploy-preview-5102--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5102--docusaurus-2.netlify.app/ |
|
Size Change: 0 B Total Size: 635 kB ℹ️ View Unchanged
|
|
✔️ [V2] 🔨 Explore the source changes: 88d9d11 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60dc88b6d9d17100070eae73 😎 Browse the preview: https://deploy-preview-5102--docusaurus-2.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Our prod can't deploy: https://app.netlify.com/sites/docusaurus-2/deploys/60dc4c6287cf5600078e2098
We are trying to redirect path
/debug.htmlto/debug/debug.htmlis the content file for path/debugThe redirect file can't be:
/debug.htmlbecause it would override the original content file (we should never do that)/debug.html/index.htmlbecause on Unix, it's not possible to create a folder with the same name as another file (the error we have here)The only remaining solution to do this redirect locally remains to use this redirect filename:
/debug.html.html(yes it looks weird)Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
test + prod deployment