Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): remove webpackConfig.resolve.symlinks: true #5126

Merged
merged 4 commits into from
Jul 8, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Jul 8, 2021

Motivation

remove webpackConfig.resolve.symlinks: true

This might not be intuitive, but to make Docusaurus work with symlinked folders, we have to use default/false instead.

Should fix #3272

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

tests + preview

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Jul 8, 2021
@slorber slorber requested a review from lex111 as a code owner July 8, 2021 15:34
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 8, 2021
@netlify
Copy link

netlify bot commented Jul 8, 2021

✔️ [V2]

🔨 Explore the source changes: 05dcd1f

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60e723004c10270009886b85

😎 Browse the preview: https://deploy-preview-5126--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 95
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5126--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Size Change: +1.24 kB (0%)

Total Size: 696 kB

Filename Size Change
website/.docusaurus/globalData.json 58.7 kB +420 B (+1%)
website/build/assets/js/main.********.js 447 kB +819 B (0%)
ℹ️ View Unchanged
Filename Size
website/build/assets/css/styles.********.css 87.6 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.8 kB
website/build/docs/introduction/index.html 235 B
website/build/index.html 33.6 kB

compressed-size-action

@felipecrs
Copy link
Contributor

Any chance this can be reapplied?

@slorber
Copy link
Collaborator Author

slorber commented Jan 24, 2022

Any chance this can be reapplied?

Do you mean setting true or false?

Because we reverted this change in #5164, but now we could try again to reapply this PR's changes

But why do you care, considering you can easily change this setting yourself by using a plugin + configureWebpack hook?

@felipecrs
Copy link
Contributor

I mean to have symlinks: false as default. I don't really care much, as the local plugin approach works fine for me. I just wondered if it wasn't better to have this default in case it does not bring any drawback anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using symlinked docs folder: Module parse failed: Assigning to rvalue
3 participants