fix(v2): improve work of useCollapsible hook with multiple clicks #5146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: cbfb571 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60ebf3e0e47b1a000749f2e3 😎 Browse the preview: https://deploy-preview-5146--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5146--docusaurus-2.netlify.app/ |
|
Size Change: -6 B (0%) Total Size: 965 kB ℹ️ View Unchanged
|
|
Thanks! also noticed this annoying behavior, happy to get this fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the
useCollapsiblehook does not respond well to multiple clicks, especially when the current transition has not yet completed.This is especially noticeable on mobile devices: for example, transition for collapsed action is not smooth anymore, so that the content is hidden instantly.
Moreover, you have to wait for the transition to finish before starting new one, otherwise there will also be "sharp" transition.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)