fix(v2): add base URL to content attribute of head tags PWA #5185
Conversation
| } | ||
|
|
||
| const attributePath = | ||
| !!path.extname(attributeValue) && attributeValue; |
There was a problem hiding this comment.
I'm not sure if really need to check for file path exists, so for now just check that attribute value contains file name.
|
✔️ [V2] 🔨 Explore the source changes: a8dfb6d 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60f0ba46d261d40007f746ab 😎 Browse the preview: https://deploy-preview-5185--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5185--docusaurus-2.netlify.app/ |
|
Size Change: +18 B (0%) Total Size: 850 kB ℹ️ View Unchanged
|
|
Going to merge this, but not 100% sure all this is a good idea in practice, maybe there will be other edge cases and we'll have only half support for baseurl 😅 anyway this shouldn't affect much users and a workaround would be easy |
Motivation
Follow-up of #5169
According to RocketValidator, we have invalid meta tag
msapplication-TileImagein whichhrefattribute should be replaced bycontent. For that case, we should also adding base URL tocontentattribute in addition to currenthrefattribute.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)