fix(v2): Fix MDX docs being considered as partials when siteDir match the _ prefix convention #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slorber I think your PR is missing a proper title? |
slorber
changed the title
|
✔️ [V2] 🔨 Explore the source changes: 1a5b9eb 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60f809e3cfcb150ad420e19b 😎 Browse the preview: https://deploy-preview-5199--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5199--docusaurus-2.netlify.app/ |
|
Size Change: +39.6 kB (+5%) 🔍 Total Size: 851 kB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Trying to fix bug reported here: #5181 (reply in thread)
When site dir or docs dir contain a _ prefix, all subfiles are wrongly considered as MDX partials. The _ prefix should only be considered inside the content folder, and parent folders should be ignored.
Also refactor the _dogfooding folder that we use extensively in this PR as e2e tests, preparing for more similar tests
Also fix page plugin ignoring options.routeBasePath (probably not very used setup but still, dogfooding permitted to surface this bug)
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
Dogfooding: move website dogfooding plugin instances to a folder starting with _ for making the failing test case:
Then fixing it
Related PRs
#5173