refactor(v2): improved Farsi default translations #5217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: 4e162ba 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/60ffa9cc1cbb210007af26a2 😎 Browse the preview: https://deploy-preview-5217--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5217--docusaurus-2.netlify.app/ |
slorber
requested changes
Jul 26, 2021
…ssoudmaboudi/docusaurus into fa-translation-massoudmaboudi
slorber
reviewed
Jul 27, 2021
| "theme.navbar.mobileSidebarSecondaryMenu.backButtonLabel": "← Back to main menu", | ||
| "theme.tags.tagsListLabel": ":برچسب ها", | ||
| "theme.lastUpdated.lastUpdatedAtBy": "آخرین بروزرسانی در {atDate} توسط {byUser}", | ||
| "theme.navbar.mobileSidebarSecondaryMenu.backButtonLabel": "← بازگشت به منو اصلی", |
There was a problem hiding this comment.
going to merge this now, but please double-check that you don't need to "flip" the arrow?
|
thanks 👍 |
slorber
changed the title
slorber
added
the
pr: polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improved default Farsi translations for the classic theme.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Run yarn run start:v2 and check that the page http://localhost:3000/ is rendered properly.
Related PRs
No