Fix search bar width for mobile nav #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
approved these changes
Apr 17, 2018
|
Will this work if the project is named "this is a stupidly long name 🤷♂️"? EDIT:
Oh |
|
@SimenB Yeah, it might not fix in all cases, possibly. But it should be a good temp fix for short/normally name projects I think what we probably want to do is put the versioning with the header links or something. Or maybe even remove the project name from the top row. Something like that. |
|
In other words - we are at a better state than we were with this fix; not perfect yet. Worth merging though. |
|
Yeah, just removing the project name altogether on lower resolutions sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #571. Shorten search bar by 10% on mobile since it doesn't really make too big of a visual difference being shorter.
This is just a quick fix and the nav bar CSS could probably be improved. There's no need for a
min-device-widthin the media query as the search bar should probably be shortenened for devices below themin-device-widthas well.This fix shouldn't affect existing users as shortening the search bar should be a backward-compatible change.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Tested on latest device resolutions in Chrome Devtools. This width works well on all of the devices available, even iPhone 5S, which is only 320px wide.
The following screenshots were taken on Pixel 2.
Before
After