Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Drone Deployment docs #5801

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

gabrielfalcao
Copy link
Contributor

Motivation

I was following the docs to deploy on Drone, but ran into a few issues:

  • The key was not being properly set
  • The command npm run publish-gh-pages no longer works.
  • The latest version of Drone retrieves secrets differently.

Have you read the Contributing Guidelines on pull requests?

yes.

Relevant Changes

  • Fix typo in "echo" command
  • Update command to "npm run deploy"
  • Update Drone config to use secrets properly

- Fix typo in "echo" command
- Update command to "npm run deploy"
- Update Drone config to use secrets properly
@facebook-github-bot
Copy link
Contributor

Hi @gabrielfalcao!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Oct 27, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 5441aaf

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6179a6f41d372200083cff65

😎 Browse the preview: https://deploy-preview-5801--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 79
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5801--docusaurus-2.netlify.app/

@lex111 lex111 added the pr: documentation This PR works on the website or other text documents in the repo. label Oct 27, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 27, 2021
@slorber
Copy link
Collaborator

slorber commented Oct 29, 2021

LGTM thanks 👍

publish-gh-pages was command from Docusaurus v1 afaik

@slorber slorber changed the title Update Drone Deployment docs docs: Update Drone Deployment docs Oct 29, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@slorber slorber merged commit b5b2c18 into facebook:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants