-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: require Node 14 #5812
Merged
Merged
chore: require Node 14 #5812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
pr: breaking change
Existing sites may not build successfully in the new version. Description contains more details.
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
labels
Oct 28, 2021
✔️ [V2] 🔨 Explore the source changes: abffab6 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617abaa5b306300007c47949 😎 Browse the preview: https://deploy-preview-5812--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5812--docusaurus-2.netlify.app/ |
Size Change: 0 B Total Size: 847 kB ℹ️ View Unchanged
|
This means: Full ESM support! |
tnir
added a commit
to tnir/forem-docs
that referenced
this pull request
Apr 12, 2022
Netlify uses Node.js 12 as default, but Docusaurus droped Node.js 12 support at v2.0.0-beta.9: facebook/docusaurus#5812 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
added a commit
to tnir/forem-docs
that referenced
this pull request
Apr 12, 2022
Netlify uses Node.js 12 as default, but Docusaurus dropped Node.js 12 support at v2.0.0-beta.9: facebook/docusaurus#5812 Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: breaking change
Existing sites may not build successfully in the new version. Description contains more details.
pr: maintenance
This PR does not produce any behavior differences to end users when upgrading.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Require Node.js >= 14
We want to upgrade react-dev-server and react-dev-utils in #5420, but CRA/react-dev-utils will require Node.js 14 too on the upcoming Webpack 5 release.
About the Node upgrade strategy:
Have you read the Contributing Guidelines on pull requests?
(Write your answer here.)
Test Plan
CI