Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use @docusaurus/react-loadable as package alias + include types #5819

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Oct 29, 2021

Motivation

Fix for @types/react-loadable depending on Webpack 4, creating conflicts for some users.

Fixes #5772

See also DefinitelyTyped/DefinitelyTyped#56726

Using npm package aliases permits to more easily remove hacky module-alias.

It seems supported by all major package managers for a long time: npm 9.6, yarn 1, pnpm...

so it looks like a good solution to use forked libs in both Webpack+Node.

This also allows other tools like eslint to understand this aliasing.

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

CI should pass

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 29, 2021
@slorber slorber requested a review from lex111 as a code owner October 29, 2021 08:20
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 29, 2021
@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ [V2]

🔨 Explore the source changes: e4bb188

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/617bb0a99796080008ef4384

😎 Browse the preview: https://deploy-preview-5819--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5819--docusaurus-2.netlify.app/

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

Size Change: 0 B

Total Size: 847 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 38 kB
website/build/assets/css/styles.********.css 94 kB
website/build/assets/js/main.********.js 425 kB
website/build/blog/2017/12/14/introducing-docusaurus/index.html 68.2 kB
website/build/blog/index.html 39 kB
website/build/docs/index.html 46.1 kB
website/build/docs/installation/index.html 53.6 kB
website/build/index.html 31.6 kB
website/build/tests/docs/index.html 27.3 kB
website/build/tests/docs/standalone/index.html 23.8 kB

compressed-size-action

@slorber slorber merged commit 0b2d348 into main Oct 29, 2021
@slorber slorber deleted the slorber/fix-react-loadable-types branch October 29, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency of @types/react-loadable causes type conflict issues in 2.0.0-beta.7/8
2 participants