fix: use @docusaurus/react-loadable as package alias + include types #5819
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix for
@types/react-loadable
depending on Webpack 4, creating conflicts for some users.Fixes #5772
See also DefinitelyTyped/DefinitelyTyped#56726
Using npm package aliases permits to more easily remove hacky
module-alias
.It seems supported by all major package managers for a long time: npm 9.6, yarn 1, pnpm...
so it looks like a good solution to use forked libs in both Webpack+Node.
This also allows other tools like eslint to understand this aliasing.
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
CI should pass