Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize editor configs for cross-platform development #628

Merged
merged 1 commit into from
May 3, 2018
Merged

Standardize editor configs for cross-platform development #628

merged 1 commit into from
May 3, 2018

Conversation

yangshun
Copy link
Contributor

@yangshun yangshun commented May 3, 2018

Motivation

We have Windows contributors as well, this PR standardizes some platform differences and makes it easier for them to contribute.

I referenced multiple .editorconfig and .gitattribute files across the popular repos to find out the most reasonable settings and added them in this PR. Repos I looked at:

.editorconfig:

.gitattributes:

I'm hoping @zenflow can help to test Docusaurus development on Windows locally and if this works, we can add these files as part of the scaffolded files.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

NA since it does not touch code. Should be fine if preview build succeeds.

Related PRs

#583 attempts to fix it in code. I believe fixing it in config is a more usual and robust approach.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 3, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 613f880

https://deploy-preview-628--docusaurus-preview.netlify.com

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Another good step to better Windows support.

@JoelMarcey JoelMarcey merged commit c31ab68 into facebook:master May 3, 2018
@yangshun yangshun deleted the standardize-configs branch May 3, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants