-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(search-algolia): allow disabling search page and configuring path #6692
Conversation
packages/docusaurus-theme-search-algolia/src/validateThemeConfig.ts
Outdated
Show resolved
Hide resolved
✔️ [V2] 🔨 Explore the source changes: 5920411 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/620d18ceb99ab10008e33ab5 😎 Browse the preview: https://deploy-preview-6692--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6692--docusaurus-2.netlify.app/ |
Size Change: +47 B (0%) Total Size: 780 kB
ℹ️ View Unchanged
|
packages/docusaurus-theme-search-algolia/src/validateThemeConfig.ts
Outdated
Show resolved
Hide resolved
3e50531
to
eb4cc3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 just minor TS tweaks
packages/docusaurus-theme-search-algolia/src/theme-search-algolia.d.ts
Outdated
Show resolved
Hide resolved
Done. And yes, opensearch without the dedicated search page makes no sense. |
LGTM thanks 👍 |
Motivation
As was rightly pointed out earlier, the search page from the Algolia theme should be disableable like as well as its default path should be changeable.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Try to set
false
value foralgolia.searchPage
to disable search page.Related PRs