docs: add Seven-innovation-base to showcase #7144
Conversation
redhat123456
requested review from
slorber,
lex111 and
Josh-Cena
as code owners
|
Hi @redhat123456! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
改好了，请大佬过目 @Josh-Cena |
|
这机器人看起来还挺有趣的，能否介绍一下 |
|
Please remember to sign the CLA, or I can't merge :) All the other stuff I can take care of before merging |
The CLA bot? It's just connected to Facebook's CLA registry, and every time you send a PR, it checks if the registry has a record associated with your email. |
|
专业的回答 我也是搞数学的数学人，以后可以多多交流😁 |
Josh-Cena
changed the title
Josh-Cena
added
the
pr: documentation
|
谢谢大佬，我就说刚刚怎么就报错了 |
|
Yeah, now it's just the CLA left. If you've signed it it should be updated within a few hours. We can just wait :) |
|
不知道怎么CLA签名 （ 😭 |
|
Select "individual" here: https://code.facebook.com/cla, provide your information, read the agreement, check the "I agree", and submit. |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
okok |
|
明白了 |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-7144--docusaurus-2.netlify.app/ |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
| @@ -25,7 +25,7 @@ await Promise.all( | |||
| new URL(`../../website/src/data/showcase/${img}`, import.meta.url), | |||
| ); | |||
| const {width, height} = imageSize(imgPath); | |||
| if (width === 640 && height === 320) { | |||
| if (width === 640 && height === 320 && imgPath.endsWith('.png')) { | |||
There was a problem hiding this comment.
what's the purpose of this new condition?
There was a problem hiding this comment.
We normalize JPEG images to PNG, but if an image has 640×320 dimensions it will be ignored and stay as JPEG.
Josh-Cena
added
pr: showcase
and removed
pr: documentation
Motivation
Have you read the Contributing Guidelines on pull requests?
Test Plan
Related PRs