-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade Infima to alpha.39 #7306
Conversation
packages/docusaurus-theme-classic/src/theme/BlogPostAuthor/index.tsx
Outdated
Show resolved
Hide resolved
Size Change: -2.3 kB (0%) Total Size: 804 kB
ℹ️ View Unchanged
|
CSS is reordered. @slorber I think we should only keep one selector from Infima? |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the changes in this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.2kB reduction is pretty impressive 👍
If we have the purge CSS plugin, we can probably optimize it further
Oh, haha, the |
This looks cool 😀 |
Yes, that's why I created PR #7152 to fix this
I like it too, I think we can shorten first column by using just the path as URL text. |
Agree. Want to do that right now? Ideally, we can use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Anything left to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
Anything left to change?
👍 agree the lighthouse check is nice and using pathname is better what about also adding blog list + blog entry here? If it's not expensive it's worth checking multiple pages |
Yes, that's what I meant, let's do it in a separate PR. This PR is ready to merge, I guess. |
I guess it's fine to keep it for now. We see when unexpected order changes happen inside Infima, even if we can safely ignore those |
Pre-flight checklist
Motivation
Many small changes, also slightly adjusted colors for Prism theme, and collapse/expand button bg made less contrast for dark mode.
Test Plan
Preview