-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mermaid): fix Mermaid integration for v9.2 release #8282
Conversation
Hi, A temporary workaround : using Yarn, adding
Thanks @Josh-Cena and @homotechsual on #help-and-questions ;) |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
The issue has been fixed in Mermaid 9.2.2 and everything seems to work fine again now Had to change a bit the types to make it work again because new official types are not exactly the same as the DefinitivelyTyped ones |
Size Change: +12.9 kB (+1%) Total Size: 885 kB
ℹ️ View Unchanged
|
Upgrading for 9.1.7 to 9.2 makes the Mermaid theme compilation fails
Unfortunately users are upgraded automatically due to using the semver range
^9.1
, and it also fails at runtime for these users that should force v9.1.7 (last version that works)See:
Current PR is a draft, still unsolved 😅
Probably unrelated to the issue (according to my local tests) but the theme/client Mermaid apis were not compiled with the correct TS options (ie outputs CJS instead of ESM), so I'm also fixing that here.