-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade clsx to 2.0.0 #9464
Conversation
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
@slorber Hi, is there any updates to this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember I had problems before with upgrading, but since it builds fine, I guess it is fine :)
LGTM thanks 👍 I guess it's fine to not consider this as a breaking change considering the impact should be very minimal and usage is mostly internal |
Missed it but an unfortunate result of this upgrade is that we now have twice the lib in our client bundle. Wondering if we'll backport this? 🤔 @carloskelly13 any plan to upgrade clsx in prism-react-renderer? |
clsx is extremely small so not a huge deal. Upgrading would certainly be better, though. |
Opened a PR: FormidableLabs/prism-react-renderer#232 |
@slorber Prism React Renderer 2.3.0 with clsx 2.0 is published. https://github.com/FormidableLabs/prism-react-renderer/releases/tag/prism-react-renderer%402.3.0 Thanks @harryzcy for the PR! |
thanks ❤️ |
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Pre-flight checklist
Motivation
Upgrading clsx to 2.0.0 doesn't seems to effect anything.
According to their release note, the breaking change is "Add "exports" map for native ESM support", which shouldn't effect docusaurus.
Test Plan
Test links
clsx
v2.0.0 release note: https://github.com/lukeed/clsx/releases/tag/v2.0.0Deploy preview: https://deploy-preview-9464--docusaurus-2.netlify.app/
Related issues/PRs