Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-translations): complete and improve Spanish theme translations #9872

Merged
merged 3 commits into from
Feb 22, 2024
Merged

fix(theme-translations): complete and improve Spanish theme translations #9872

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f94c66
Updated es/theme-common.json
4troDev Feb 20, 2024
163a84e
Update theme-common.json
4troDev Feb 20, 2024
11cb077
Update packages/docusaurus-theme-translations/locales/es/theme-common…
slorber Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/docusaurus-theme-translations/locales/es/theme-common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,18 @@
"theme.BackToTopButton.buttonAriaLabel": "Volver al principio",
"theme.CodeBlock.copied": "Copiado",
"theme.CodeBlock.copy": "Copiar",
"theme.CodeBlock.copyButtonAriaLabel": "Copiar código al portapapeles",
4troDev marked this conversation as resolved.
Show resolved Hide resolved
"theme.CodeBlock.copyButtonAriaLabel": "Copiar código",
"theme.CodeBlock.wordWrapToggle": "Alternar ajuste de palabras",
"theme.DocSidebarItem.collapseCategoryAriaLabel": "Collapse sidebar category '{label}'",
"theme.DocSidebarItem.expandCategoryAriaLabel": "Expand sidebar category '{label}'",
"theme.DocSidebarItem.collapseCategoryAriaLabel": "Colapsar categoría de barra lateral '{label}'",
"theme.DocSidebarItem.expandCategoryAriaLabel": "Ampliar la categoría de la barra lateral '{label}'",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not Spanish but that doesn't look good to me. {label} is the name of the category, not the name of the sidebar. Wouldn't it be better to put this placeholder closer to the "categoria" word?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it applies to Spanish, but what we have in French:

  "theme.DocSidebarItem.collapseCategoryAriaLabel": "Réduire la catégorie '{label}' de la barre latérale",
  "theme.DocSidebarItem.expandCategoryAriaLabel": "Développer la catégorie '{label}' de la barre latérale",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

{Label} is a place holder if i change it when there is a Label it won't show up since is not in the code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm i understand now what you mean it should be “Reducir la categoría '{label}' de la barra lateral”,

slorber marked this conversation as resolved.
Show resolved Hide resolved
"theme.ErrorPageContent.title": "Esta página ha fallado.",
"theme.ErrorPageContent.tryAgain": "Intente de nuevo",
"theme.NavBar.navAriaLabel": "Principal",
"theme.NotFound.p1": "No pudimos encontrar lo que buscaba.",
"theme.NotFound.p2": "Comuníquese con el dueño del sitio que lo vinculó a la URL original y hágale saber que su vínculo está roto.",
"theme.NotFound.title": "Página No Encontrada",
"theme.TOCCollapsible.toggleButtonLabel": "En esta página",
"theme.admonition.caution": "caution",
"theme.admonition.caution": "precaución",
"theme.admonition.danger": "danger",
"theme.admonition.info": "info",
"theme.admonition.note": "note",
Expand Down Expand Up @@ -51,7 +51,7 @@
"theme.docs.sidebar.collapseButtonTitle": "Colapsar barra lateral",
"theme.docs.sidebar.expandButtonAriaLabel": "Expandir barra lateral",
"theme.docs.sidebar.expandButtonTitle": "Expandir barra lateral",
"theme.docs.sidebar.navAriaLabel": "Docs barra lateral",
4troDev marked this conversation as resolved.
Show resolved Hide resolved
"theme.docs.sidebar.navAriaLabel": "Barra lateral de Documentos",
"theme.docs.sidebar.toggleSidebarButtonAriaLabel": "Alternar barra lateral",
"theme.docs.tagDocListPageTitle": "{nDocsTagged} con \"{tagName}\"",
"theme.docs.tagDocListPageTitle.nDocsTagged": "Un documento etiquetado|{count} documentos etiquetados",
Expand Down
Loading