Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update legacy MDX v1 links to markdown links #9913

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

OzakIOne
Copy link
Contributor

@OzakIOne OzakIOne commented Mar 5, 2024

Motivation

Moving from legacy syntax to markdown syntax for links allows broken link checker to check links

Test Plan

Deploy preview

Test links

Client redirect

Content blog

Content doc

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 5, 2024
Copy link

netlify bot commented Mar 5, 2024

[V2]

Name Link
🔨 Latest commit a7e09dc
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65e7494f5f31760008af3da2
😎 Deploy Preview https://deploy-preview-9913--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 5, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 60 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 69 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 63 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 68 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 75 🟢 100 🟢 100 🟢 90 🟠 88 Report

@slorber slorber added the Argos Add this label to run UI visual regression tests. See argos.yml GH action. label Mar 5, 2024
Copy link

argos-ci bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 🧿 Changes detected (Review) 1 changed Mar 5, 2024, 7:12 PM

@OzakIOne
Copy link
Contributor Author

OzakIOne commented Mar 5, 2024

Argos change is normal it's because of this :
image

The old doc was using <code> for each param, while all the other lines user only one <code> for all params

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 5, 2024
@slorber
Copy link
Collaborator

slorber commented Mar 5, 2024

I see thanks 👍 LGTM

@slorber slorber marked this pull request as ready for review March 5, 2024 19:03
@slorber slorber changed the title docs: update legacy links to markdown links docs: update legacy MDX v1 links to markdown links Mar 5, 2024
@slorber slorber merged commit 05279dc into main Mar 5, 2024
10 of 11 checks passed
@slorber slorber deleted the ozaki/legacyDocsUpdate branch March 5, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Argos Add this label to run UI visual regression tests. See argos.yml GH action. CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants