Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Bump spectron from 11.0.0 to 14.0.0 in /desktop (#2071)
Browse files Browse the repository at this point in the history
Summary:
allow-large-files
Bumps [spectron](https://github.com/electron/spectron) from 11.0.0 to 14.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/electron/spectron/releases">spectron's releases</a>.</em></p>
<blockquote>
<h2>v13.0.0</h2>
<p>No release notes provided.</p>
<h2>v12.0.0</h2>
<p>No release notes provided.</p>
<h2>v11.1.0</h2>
<p>Upgraded webdriverio to 6.1.20 <a href="https://github.com/electron/spectron/issues/631">https://github.com/facebook/flipper/issues/631</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/electron/spectron/commits">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=spectron&package-manager=npm_and_yarn&previous-version=11.0.0&new-version=14.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: #2071

Test Plan:
Imported from GitHub, without a `Test Plan:` line.

yarn test-e2e

Test Suite Succeded after running yarn test-e2e

Reviewed By: passy

Differential Revision: D27230110

Pulled By: priteshrnandgaonkar

fbshipit-source-id: d6d2d6c1482fa563b9dde9472467f918496e2cea
  • Loading branch information
dependabot[bot] authored and facebook-github-bot committed Mar 23, 2021
1 parent 12717e1 commit fd9b5b5
Show file tree
Hide file tree
Showing 3 changed files with 528 additions and 325 deletions.
6 changes: 3 additions & 3 deletions desktop/e2e/open.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ async function testSuite(app: Application) {
await app.client.waitUntilWindowLoaded();
app.browserWindow.focus();
await app.client.waitUntilTextExists('html', 'Changelog');
await app.client.$('div[type="primary"]=Close').click();
await app.client.$('div=Manage Plugins').click();
(await app.client.$('div[type="primary"]=Close')).click();
(await app.client.$('div=Manage Plugins')).click();
}

export default function test() {
Expand All @@ -54,7 +54,7 @@ export default function test() {
})
.then(function (title) {
// Verify the window's title
assert.equal(title, 'Flipper');
assert.equal(title.includes('Flipper'), true);
})
.then(async function () {
await testSuite(app);
Expand Down
2 changes: 1 addition & 1 deletion desktop/e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"bugs": "https://github.com/facebook/flipper/issues",
"dependencies": {},
"devDependencies": {
"spectron": "^11.0.0"
"spectron": "^14.0.0"
},
"scripts": {
"test": "../ts-node ./main.ts"
Expand Down
Loading

0 comments on commit fd9b5b5

Please sign in to comment.