[parser] fix patterned catch

Reviewed By: gabelevi Differential Revision: D5725431 fbshipit-source-id: 8ed21e7322b1f3153fe0fba6762b8fa9c76c5525
facebook · Aug 29, 2017 · d2b8633 · d2b8633
1 parent 1e4f3e5
commit d2b8633
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 396 deletions.
diff --git a/src/parser/statement_parser.ml b/src/parser/statement_parser.ml
@@ -392,12 +392,7 @@ module Statement
         let catch = with_loc (fun env ->
           Expect.token env T_CATCH;
           Expect.token env T_LPAREN;
-          let id = Parse.identifier ~restricted_error:Error.StrictCatchVariable env in
-          let param = fst id, Pattern.Identifier { Pattern.Identifier.
-            name = id;
-            typeAnnotation = None;
-            optional = false;
-          } in
+          let param = Parse.pattern env Error.StrictCatchVariable in
           Expect.token env T_RPAREN;
           let body = Parse.block_body env in
           { Ast.Statement.Try.CatchClause.

diff --git a/src/parser/test/esprima/ES6/binding-pattern/array-pattern/empty-pattern-catch-param.skip b/src/parser/test/esprima/ES6/binding-pattern/array-pattern/empty-pattern-catch-param.skip
diff --git a/src/parser/test/esprima/ES6/binding-pattern/array-pattern/patterned-catch.skip b/src/parser/test/esprima/ES6/binding-pattern/array-pattern/patterned-catch.skip
diff --git a/src/parser/test/esprima/ES6/binding-pattern/array-pattern/with-default-catch-param.skip b/src/parser/test/esprima/ES6/binding-pattern/array-pattern/with-default-catch-param.skip
diff --git a/src/parser/test/esprima/ES6/binding-pattern/object-pattern/empty-catch-param.skip b/src/parser/test/esprima/ES6/binding-pattern/object-pattern/empty-catch-param.skip