Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to call private class property #4872

Closed
TrySound opened this issue Sep 13, 2017 · 1 comment
Closed

Unable to call private class property #4872

TrySound opened this issue Sep 13, 2017 · 1 comment

Comments

@TrySound
Copy link
Contributor

Calling private property failed with not existing method
https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVBTAHgBzgJwBcwBjGAQwGdKwBBMAb1QEgBiEuAWxwFdCMwAXjAAKcgEohAPkaow8sM3wZCPfADsw5MAGowARgDcchQF9jCsHOYBzFUNHkAXGEqF8AS3U3JgmU0t5ZVUNMEIACw9KADp2Ll5+MXELM2NTVCA

Also currently spec omits this., but flow parser failed on unexpected #
https://github.com/tc39/proposal-private-fields#a-brief-introduction
https://flow.org/try/#0PQKgBAAgZgNg9gdzCYAoVBTAHgBzgJwBcwBjGAQwGdKwBBMAb1QEgBiEuAWxwFdCMwAXjAAKcgEohAPkaow8sM3wZCPfADsw5MAGowARgDcchQF9jCsHOYBzFUNHkAXGEqF8AS3U3JgmU0t5ZVUNMHYuXn4xcQszY1NUIA
facebook-github-bot pushed a commit that referenced this issue Aug 17, 2021
@SamChou19815 @facebook-github-bot
[private-method] Type checking private methods
9d7b2a7 
Summary:
This diff adds support for type checking private methods.

I added private methods and private static methods into the same class entries that stores type signature of private fields, and then use these type signature information to resolve `GetPrivatePropT` and `PrivateMethodT`. I also ensured that unbinding private methods are also correctly errored on, similar to unbound public methods.

Fixes #6254 #4872 #7877.

Reviewed By: jbrown215

Differential Revision: D30023778

fbshipit-source-id: 5575306de4ac504a92fb8bba221221566b5ac52d
facebook-github-bot pushed a commit that referenced this issue Aug 18, 2021
@SamChou19815 @facebook-github-bot
[private-method] Type checking private methods
bc557ea 
Summary:
This diff adds support for type checking private methods.

I added private methods and private static methods into the same class entries that stores type signature of private fields, and then use these type signature information to resolve `GetPrivatePropT` and `PrivateMethodT`. I also ensured that unbinding private methods are also correctly errored on, similar to unbound public methods.

Fixes #6254 #4872 #7877.

Reviewed By: jbrown215

Differential Revision: D30023778

fbshipit-source-id: 71fae1a81d9b373f18b9ec4743380e846564a49f
@gkz
Copy link
Member

gkz commented Aug 25, 2021

Fixed in referenced commit

@gkz gkz closed this as completed Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkz @TrySound