Allow simultaneous named and default imports #600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | None -> | ||
| failwith ( | ||
| "Parser error: Non-default imports must have a set of " ^ | ||
| "named import specifiers!" |
There was a problem hiding this comment.
Isn't it possible to import for side effects only, without specifying any bindings, default or non? See #574 for an issue, and the spec at 15.2.2; import ModuleSpecifier.
There was a problem hiding this comment.
Oh yea, forgot about that issue. Will fix now
|
Cool! This is a simple enough diff, and clearly does what it says on the tin. For tracking purposes, this fixes #525. |
jeffmo
force-pushed
the
import_default_and_named
branch
from
d5f06c6
to
a50ae40
Compare
|
Just want to report in saying that I merged this temporarily on my local repo and it works as intended for me. Will run the full test suite and report back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Flow considered
import Foo from ...andimport Foo, {Bar, Baz} from ...to be mutually exclusive -- though they should not be (per spec).This fixes Flow to properly handle
import Foo, {Bar, Baz} from ...