Skip to content

Commit

Permalink
folly/coro/Coroutine.h: avoid a -Wdeprecated-this-capture warning
Browse files Browse the repository at this point in the history
Summary:
Avoid build failure with xcode 15.4.
While -Wdeprecated-experimental-coroutine was deleted in upstream llvm17,
`__APPLE__` llvm reflects that deletion in their version llvm16.
Updating to xcode 16.0.0 RC1 makes this change unnecessary.

Reviewed By: Orvid

Differential Revision: D62769728

fbshipit-source-id: 584ca8b09a3bce54fb5efa2365a9f447029db020
  • Loading branch information
Jim Meyering authored and facebook-github-bot committed Sep 17, 2024
1 parent 366de7f commit 5bf165e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion folly/coro/Coroutine.h
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@ struct detect_promise_return_object_eager_conversion_ {
// unblock expected/optional coroutines. This should be removed once the
// build config is changed to use -Wno-deprecated-experimental-coroutine.
FOLLY_PUSH_WARNING
#if defined(__clang__) && (__clang_major__ < 17 && __clang_major__ > 13)
#if defined(__clang__) && \
(13 < __clang_major__ && __clang_major__ < 17 - defined(__APPLE__))
FOLLY_CLANG_DISABLE_WARNING("-Wdeprecated-experimental-coroutine")
#endif
co_return;
Expand Down

0 comments on commit 5bf165e

Please sign in to comment.