Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make it possible to cleanly #include <folly/portability/GTest.h>
Summary: Prior to this change, attempting to: ``` #include <folly/portability/GTest.h> ``` would result in a lint error: ``` ~/fbsource$ arc lint -e extra >>> Lint for xplat/arfx/engine/plugins/impl/gltf/tests/system/sender/ModifiedSenderTest.cpp: Advice (CLANGTIDY) facebook-unused-include-check seemingly used include folly/portability/GTest.h only serves as an umbrella to other headers; you may want to include those directly instead; info/bugs: https://fburl.com/include 5 #include <xplat/arfx/engine/plugins/impl/gltf/model/Mesh.hpp> 6 #include <xplat/arfx/engine/plugins/impl/gltf/model/Node.hpp> 7 >>> 8 #include <folly/portability/GTest.h> 9 10 namespace arfx::engine::runtime::gltf { 11 ``` This is a problem because the portability wrapper is needed to keep xplat tests working correctly on Citadel/windows. Reviewed By: francoiscoulombe Differential Revision: D60969223 fbshipit-source-id: 4d250151bc2b0e948b3ec743a44367c2027f5af0
- Loading branch information