Fix hardcoded page size in test (#2276)

Summary: This test segfaults on Nvidia's grace cpus since the page size for them is 64kb. Replacing the hardcoded value fixes the issue. Pull Request resolved: #2276 Reviewed By: yfeldblum Differential Revision: D60919932 Pulled By: Orvid fbshipit-source-id: 346c9441f92f20f2a01aff0443e3d89e9fcb251c
facebook · Aug 16, 2024 · a2aae6d · a2aae6d
1 parent 4b65742
commit a2aae6d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/folly/test/BUCK b/folly/test/BUCK
@@ -1360,6 +1360,7 @@ cpp_unittest(
         "//folly/portability:gmock",
         "//folly/portability:gtest",
         "//folly/portability:sys_mman",
+        "//folly/portability:unistd",
     ],
     external_deps = [
         ("boost", None, "boost_algorithm"),

diff --git a/folly/test/RangeTest.cpp b/folly/test/RangeTest.cpp
@@ -33,6 +33,7 @@
 #include <folly/portability/GMock.h>
 #include <folly/portability/GTest.h>
 #include <folly/portability/SysMman.h>
+#include <folly/portability/Unistd.h>
 
 #if __has_include(<range/v3/range/concepts.hpp>)
 #include <range/v3/range/concepts.hpp>
@@ -1052,7 +1053,7 @@ TYPED_TEST(NeedleFinderTest, Base) {
   }
 }
 
-const size_t kPageSize = 4096;
+const size_t kPageSize = sysconf(_SC_PAGESIZE);
 // Updates contents so that any read accesses past the last byte will
 // cause a SIGSEGV.  It accomplishes this by changing access to the page that
 // begins immediately after the end of the contents (as allocators and mmap()