-
Notifications
You must be signed in to change notification settings - Fork 648
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Use the `cmake` crate instead of relying on an existing build of Hermes. The crate puts the libraries in a given destination path, whence they can be linked by `build.rs` directives. It also handles the use of `--release` and sets the optimization and debug flags automatically. We have to `rerun-if-changed` in the relevant directories, but we can't include the entire `hermes` directory because that would capture all the other `juno` crates as well. Reviewed By: tmikov Differential Revision: D33714180 fbshipit-source-id: c68deea1fa652d46abda14185240e0db6b186127
- Loading branch information
1 parent
67fe974
commit 6c53047
Showing
5 changed files
with
63 additions
and
42 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,4 +12,4 @@ libc = "0.2" | |
thiserror = "1.0" | ||
|
||
[build-dependencies] | ||
toml = "=0.5.7" | ||
cmake = "0.1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,4 +13,4 @@ thiserror = "1.0" | |
url = "2.2.2" | ||
|
||
[build-dependencies] | ||
toml = "=0.5.7" | ||
cmake = "0.1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters