Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unset public properties also cause calls to __unset() #1930

Closed
wants to merge 11 commits into from
Closed

Unset public properties also cause calls to __unset() #1930

wants to merge 11 commits into from

Commits on Mar 9, 2014

  1. Test: unset public properties also cause calls to __unset()

    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    71af7c9 View commit details
    Browse the repository at this point in the history

  2. Checking also protected properties as of @staabm's review

    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    2afaae9 View commit details
    Browse the repository at this point in the history

  3. Applying hotfix - public properties that are unset also cause __unset… 

    … calls
    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    5e30cf6 View commit details
    Browse the repository at this point in the history

  4. Only non-accessible properties cause fatals

    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    ab31f00 View commit details
    Browse the repository at this point in the history

  5. Adding tests to verify that private/protected property unset causes f… 

    …atals
    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    3c26750 View commit details
    Browse the repository at this point in the history

  6. Fixed fatal format (minor technical diffs)

    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    685554f View commit details
    Browse the repository at this point in the history

  7. Denying unset of private/protected properties

    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    0ccfe73 View commit details
    Browse the repository at this point in the history

  8. Caching local method call when verifying if __unset shall be called

    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    e2bee64 View commit details
    Browse the repository at this point in the history

  9. Throwing fatals on inaccessible property only if the property is defi… 

    …ned in the class
    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    4478272 View commit details
    Browse the repository at this point in the history

  10. Moving tests related to facebook#1930 to the correct test directory u… 

    …nder `/slow`
    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    82dbff4 View commit details
    Browse the repository at this point in the history

  11. Only inaccessible properties cause fatals on unset when no __unset … 

    …is defined
    @Ocramius
    Ocramius committed Mar 9, 2014
    Configuration menu
    Copy the full SHA
    98efded View commit details
    Browse the repository at this point in the history