Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant eslint max-len overrides #3548

Merged
merged 1 commit into from
May 11, 2017

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 11, 2017

Summary
The max-len eslint rule was disabled in #3444. No reason to keep around the inline disables of it.

Test plan
yarn lint

@cpojer cpojer merged commit 4ab665b into jestjs:master May 11, 2017
@cpojer
Copy link
Member

cpojer commented May 11, 2017

Thanks @SimenB. This is great.

@SimenB SimenB deleted the remove-max-len branch May 11, 2017 13:43
@codecov-io
Copy link

Codecov Report

Merging #3548 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3548   +/-   ##
=======================================
  Coverage   62.28%   62.28%           
=======================================
  Files         181      181           
  Lines        6714     6714           
  Branches        6        6           
=======================================
  Hits         4182     4182           
  Misses       2529     2529           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-config/src/utils.js 81.63% <ø> (ø) ⬆️
packages/jest-validate/src/warnings.js 100% <ø> (ø) ⬆️
packages/jest-matchers/src/toThrowMatchers.js 79.62% <ø> (ø) ⬆️
packages/jest-haste-map/src/lib/extractRequires.js 100% <ø> (ø) ⬆️
packages/jest-docblock/src/index.js 100% <ø> (ø) ⬆️
packages/pretty-format/src/index.js 98.06% <ø> (ø) ⬆️
packages/jest-cli/src/lib/getTestPathPattern.js 60% <ø> (ø) ⬆️
packages/jest-message-util/src/index.js 87.05% <ø> (ø) ⬆️
packages/jest-matchers/src/matchers.js 98.35% <ø> (ø) ⬆️
packages/jest-config/src/normalize.js 90.9% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73368b1...63b5fa7. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants