-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier 1.3 #3444
Prettier 1.3 #3444
Conversation
this._pipe.write( | ||
`\n\n Pattern matches ${total} ${pluralizeTest(total)}`, | ||
); | ||
this._pipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a regression, doesn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @vjeux
I feel like there are some things that print worse than before, which is a shame, but there is no way to stop the prettier train, so we'll have to wait and see if the prettier team fixes some things for the next release. |
Thanks for pinging me, it looks indeed like it's a lot worse and someone sent a great fix for it. I'll sent 1.3.1 for it. You'll be able to revert this commit and re-apply again to get back to where it was. Sorry about it! |
* Add support for `jest.config.js`. * Update to Prettier 1.3.0.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
New release with supposedly better printing.
Test plan
yarn test