Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier 1.3 #3444

Merged
merged 2 commits into from
May 3, 2017
Merged

Prettier 1.3 #3444

merged 2 commits into from
May 3, 2017

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented May 3, 2017

Summary

New release with supposedly better printing.

Test plan

  • yarn test

this._pipe.write(
`\n\n Pattern matches ${total} ${pluralizeTest(total)}`,
);
this._pipe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a regression, doesn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @vjeux

@cpojer cpojer merged commit 7b6597f into jestjs:master May 3, 2017
@cpojer
Copy link
Member Author

cpojer commented May 3, 2017

I feel like there are some things that print worse than before, which is a shame, but there is no way to stop the prettier train, so we'll have to wait and see if the prettier team fixes some things for the next release.

@vjeux
Copy link
Contributor

vjeux commented May 3, 2017

Thanks for pinging me, it looks indeed like it's a lot worse and someone sent a great fix for it. I'll sent 1.3.1 for it. You'll be able to revert this commit and re-apply again to get back to where it was. Sorry about it!

prettier/prettier#1494

@cpojer cpojer deleted the prettier-1.3 branch May 4, 2017 15:43
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
* Add support for `jest.config.js`.

* Update to Prettier 1.3.0.
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants