testMatch should find tests in .folders #3006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like this fails on travis, you might need to sort something there. |
Codecov Report
@@ Coverage Diff @@
## master #3006 +/- ##
=======================================
Coverage 67.86% 67.86%
=======================================
Files 147 147
Lines 5349 5349
=======================================
Hits 3630 3630
Misses 1719 1719
Continue to review full report at Codecov.
|
|
Thanks! Would you mind auditing the other places we use micromatch in to make sure we cover everything? |
|
Sure thing
…On Mon, Feb 27, 2017, 02:16 Christoph Pojer ***@***.***> wrote:
Thanks! Would you mind auditing the other places we use micromatch in to
make sure we cover everything?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3006 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAEEtGL-6mGR31rnCE7wEvBx30mcVdqOks5rgjIDgaJpZM4MMWTk>
.
|
skovhus
pushed a commit
to skovhus/jest
that referenced
this pull request
Apr 29, 2017
* testMatch should find tests in .folders * dont depend on order of paths in tests
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
* testMatch should find tests in .folders * dont depend on order of paths in tests
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When a test is inside a folder that's name starts with
., they are ignored bytestMatchbut are correctly found bytestRegex. It's even more obscure if the entire project is checked out below a dot-folder, in which case all tests are ignored bytestMatchwhich is now the default way of finding tests.Test plan
yarn test