Fix testNamePattern value with interactive snapshots
#6579
Conversation
|
Thanks for the PR! Would be awesome with a test for the regression as well |
|
@SimenB Mind pointing me in the right direction on where I can add that? I looked at e2e tests, but not sure how to get those tests to accept input. I've tried adding a test to |
…napshot-testpathname
|
Ah, yes great fix. I tested this on the repro repo in #6485 and confirmed that it works 👍 afaik we don't have any integration tests for watch mode, and this is just |
|
Merged in master which should fix the node 6 issue |
|
We might wanna set up some e2e tests for watch mode. Should be easy enough to feed some keypresses into |
|
Thanks to everyone for your effort! 🎈 |
This Pull Request renovates the package group "jest monorepo". - [jest-environment-node](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` - [jest](https://github.com/facebook/jest) (`devDependencies`): from `23.2.0` to `23.3.0` # Release Notes <details> <summary>facebook/jest</summary> ### [`v23.3.0`](https://github.com/facebook/jest/blob/master/CHANGELOG.md#​2330) [Compare Source](jestjs/jest@v23.2.0...v23.3.0) ##### Features - `[jest-cli]` Allow watch plugin to be configured ([#​6603](`https://github.com/facebook/jest/pull/6603`)) - `[jest-snapshot]` Introduce `toMatchInlineSnapshot` and `toThrowErrorMatchingInlineSnapshot` matchers ([#​6380](`https://github.com/facebook/jest/pull/6380`)) ##### Fixes - `[jest-regex-util]` Improve handling already escaped path separators on Windows ([#​6523](`https://github.com/facebook/jest/pull/6523`)) - `[jest-cli]` Fix `testNamePattern` value with interactive snapshots ([#​6579](`https://github.com/facebook/jest/pull/6579`)) - `[jest-cli]` Fix enter to interrupt watch mode ([#​6601](`https://github.com/facebook/jest/pull/6601`)) ##### Chore & Maintenance - `[website]` Switch domain to https://jestjs.io ([#​6549](`https://github.com/facebook/jest/pull/6549`)) - `[tests]` Improve stability of `yarn test` on Windows ([#​6534](`https://github.com/facebook/jest/pull/6534`)) - `[*]` Transpile object shorthand into Node 4 compatible syntax ([#​6582](`https://github.com/facebook/jest/pull/6582`)) - `[*]` Update all legacy links to jestjs.io ([#​6622](`https://github.com/facebook/jest/pull/6622`)) - `[docs]` Add docs for 23.1, 23.2, and 23.3 ([#​6623](`https://github.com/facebook/jest/pull/6623`)) - `[website]` Only test/deploy website if relevant files are changed ([#​6626](`https://github.com/facebook/jest/pull/6626`)) - `[docs]` Describe behavior of `resetModules` option when set to `false` ([#​6641](`https://github.com/facebook/jest/pull/6641`)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com).
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
This fixes a regression with interactive snapshot mode where it would fail to find any tests to run in the file. Problem here is it was using the test title with regex pattern to say match the title exactly. But
testNamePatternalso includes anydescribeblocks in the title, so we need to include that as well.I switched from using the test
titletofullNameand it appears to be working as expected now. Since @rickhanlonii, you did the improvements recently, I'd love some feedback from you on this and if it is the correct way to solve it. Also if there is some end to end test that could be done to ensure this is working as intended.This fix should resolve #6485 and #6431.
Test plan
All tests pass.