Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-leak-detector] remove code repeat #8438

Merged
merged 2 commits into from
May 7, 2019

Conversation

Connormiha
Copy link
Contributor

Summary

I removed function isPrimitive from jest-leak-detector because it is already implemented in jest-get-type. DRY

Test plan

Copy link
Contributor

@jeysal jeysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Simple refactors like this would be fine without a changelog entry for me, but @scotthovestadt seems to like them so I guess it doesn't hurt 😄

@codecov-io
Copy link

Codecov Report

Merging #8438 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8438      +/-   ##
==========================================
- Coverage   62.33%   62.33%   -0.01%     
==========================================
  Files         266      266              
  Lines       10737    10736       -1     
  Branches     2614     2615       +1     
==========================================
- Hits         6693     6692       -1     
  Misses       3461     3461              
  Partials      583      583
Impacted Files Coverage Δ
packages/jest-leak-detector/src/index.ts 82.35% <100%> (-0.99%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 985d26c...fef529e. Read the comment docs.

@jeysal jeysal merged commit 7197b1c into jestjs:master May 7, 2019
This was referenced Oct 10, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants