Fix failing insertNodes when selection is null (#5956)

facebook · Apr 24, 2024 · 537054f · 537054f
1 parent 387f427
commit 537054f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/packages/lexical/src/LexicalSelection.ts b/packages/lexical/src/LexicalSelection.ts
@@ -2681,10 +2681,17 @@ export function $getTextContent(): string {
 }
 
 function removeTextAndSplitBlock(selection: RangeSelection): number {
+  let selection_ = selection;
   if (!selection.isCollapsed()) {
-    selection.removeText();
+    selection_.removeText();
   }
-  const selection_ = $getSelection();
+  // A new selection can originate as a result of node replacement, in which case is registered via
+  // $setSelection
+  const newSelection = $getSelection();
+  if ($isRangeSelection(newSelection)) {
+    selection_ = newSelection;
+  }
+
   invariant(
     $isRangeSelection(selection_),
     'Unexpected dirty selection to be null',

diff --git a/scripts/error-codes/codes.json b/scripts/error-codes/codes.json
@@ -159,5 +159,8 @@
   "157": "Expected tableNode to have a parent TableNode",
   "158": "Expected gridParent to have a parent",
   "159": "Expected focusCellParent to have a parent",
-  "160": "Expected TableCellNode parent to be a TableRowNode"
+  "160": "Expected TableCellNode parent to be a TableRowNode",
+  "161": "Unexpected dirty selection to be null",
+  "162": "Root element not registered",
+  "163": "node is not a ListNode"
 }