Address code review comments

facebook · Apr 16, 2024 · 67bc535 · 67bc535
1 parent 4e1e4ff
commit 67bc535
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/lexical-react/src/LexicalTablePlugin.ts b/packages/lexical-react/src/LexicalTablePlugin.ts
@@ -96,6 +96,7 @@ export function TablePlugin({
           const lastCellMap = gridMap[i][rowLength - 1];
           const lastRowCell = lastCellMap.cell;
           for (let j = rowLength; j < maxRowLength; ++j) {
+            // TODO: inherit header state from another header or body
             const newCell = $createTableCellNode(0);
             newCell.append($createParagraphNode());
             if (lastRowCell !== null) {

diff --git a/packages/lexical-table/src/LexicalTableUtils.ts b/packages/lexical-table/src/LexicalTableUtils.ts
@@ -715,8 +715,7 @@ export function $unmergeCell(): void {
   }
 }
 export function $computeTableMapSkipCellCheck(grid: TableNode) {
-  const cell = new TableCellNode();
-  const [tableMap] = $computeTableMapHelper(grid, cell, cell);
+  const [tableMap] = $computeTableMapHelper(grid, null, null);
   return tableMap;
 }
 
@@ -737,8 +736,8 @@ export function $computeTableMap(
 
 function $computeTableMapHelper(
   grid: TableNode,
-  cellA: TableCellNode,
-  cellB: TableCellNode,
+  cellA: null | TableCellNode,
+  cellB: null | TableCellNode,
 ): [TableMapType, TableMapValueType | null, TableMapValueType | null] {
   const tableMap: TableMapType = [];
   let cellAValue: null | TableMapValueType = null;
@@ -759,10 +758,10 @@ function $computeTableMapHelper(
         tableMap[startRow + i][startColumn + j] = value;
       }
     }
-    if (cellA.is(cell)) {
+    if (cellA !== null && cellA.is(cell)) {
       cellAValue = value;
     }
-    if (cellB.is(cell)) {
+    if (cellB !== null && cellB.is(cell)) {
       cellBValue = value;
     }
   }