Fix tab replacement composition crash

facebook · Sep 28, 2023 · 9d73c10 · 9d73c10
1 parent 0e5671a
commit 9d73c10
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/lexical/src/LexicalSelection.ts b/packages/lexical/src/LexicalSelection.ts
@@ -73,7 +73,7 @@ import {
   scrollIntoViewIfNeeded,
   toggleTextFormatType,
 } from './LexicalUtils';
-import {$createTabNode} from './nodes/LexicalTabNode';
+import {$createTabNode, $isTabNode} from './nodes/LexicalTabNode';
 
 export type TextPointType = {
   _selection: RangeSelection | GridSelection;
@@ -1205,6 +1205,15 @@ export class RangeSelection implements BaseSelection {
           }
           return;
         }
+      } else if ($isTabNode(firstNode)) {
+        // We don't need to check for delCount because there is only the entire selected node case
+        // that can hit here for content size 1 and with canInsertTextBeforeAfter false
+        const textNode = $createTextNode(text);
+        textNode.setFormat(format);
+        textNode.setStyle(style);
+        textNode.select();
+        firstNode.replace(textNode);
+        return;
       }
       const delCount = endOffset - startOffset;
 

diff --git a/packages/lexical/src/nodes/LexicalTabNode.ts b/packages/lexical/src/nodes/LexicalTabNode.ts
@@ -65,6 +65,15 @@ export class TabNode extends TextNode {
     invariant(false, 'TabNode does not support setTextContent');
   }
 
+  spliceText(
+    _offset: number,
+    _delCount: number,
+    _newText: string,
+    _moveSelection?: boolean | undefined,
+  ): TextNode {
+    invariant(false, 'TabNode does not support spliceText');
+  }
+
   setDetail(_detail: TextDetailType | number): this {
     invariant(false, 'TabNode does not support setDetail');
   }