Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Insert an image inside another image's caption #6109

Closed
MaxPlav opened this issue May 15, 2024 · 4 comments · Fixed by #6230
Closed

Bug: Insert an image inside another image's caption #6109

MaxPlav opened this issue May 15, 2024 · 4 comments · Fixed by #6230
Labels
contribution-week Issues that are good to be picked up for the contribution week good first issue Good for newcomers

Comments

@MaxPlav
Copy link
Contributor

MaxPlav commented May 15, 2024

Currently, a user can insert an image inside another image's caption which may cover up or deface the original image.
Probably a variety of elements that can be inserted in an image's caption should be limited.

Lexical version:

Steps To Reproduce

  1. Open https://playground.lexical.dev/ in Chrome
  2. Insert a sample image
  3. Click on the image caption
  4. Go to the Toolbar and insert "Image"
  5. Select from "URL".
  6. Insert a new image URI.
  7. See that the new image covers the original one.

The current behavior

Screen.Recording.2024-05-15.at.12.19.48.mov

The expected behavior

A user is not able to insert an image into the caption.

@StyleT
Copy link
Contributor

StyleT commented May 15, 2024

IMO, we shall be running there nested editor that supports only basic rich text (see examples/react-rich setup). Maybe even plain text only?

@StyleT StyleT added good first issue Good for newcomers contribution-week Issues that are good to be picked up for the contribution week labels May 15, 2024
@rabelmervin
Copy link

Hi Maxplav, I'm Rabel Mervin, I'm reaching out because I'm interested in contributing this project
Could you please provide me any processes I should follow to solve this Issue ?

@StyleT
Copy link
Contributor

StyleT commented May 16, 2024

Hi Maxplav, I'm Rabel Mervin, I'm reaching out because I'm interested in contributing this project Could you please provide me any processes I should follow to solve this Issue ?

Hi! You can start here: https://github.com/facebook/lexical/blob/main/CONTRIBUTING.md

@rabelmervin
Copy link

Thanks @StyleT for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution-week Issues that are good to be picked up for the contribution week good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants