Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground-text-format-toolbar): don't hide toolbar if current node is a paragraph #4850

Merged

Conversation

mathieumetral
Copy link
Contributor

Improve the toolbar to format text and avoid hiding it unnecessarily

Before

lexical-text-toolbar-before.mov

After

lexical-text-toolbar-after.mov

@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 3:56pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 3:56pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 31, 2023
@mathieumetral
Copy link
Contributor Author

Any updates on this PR? Maybe @ivailop7 ?

Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! I wonder if there's a more generic condition where this apply rather than ParagraphNode specifically but the proposed looks reasonable to me

@zurfyx zurfyx merged commit 9650950 into facebook:main Sep 29, 2023
39 of 43 checks passed
@mathieumetral mathieumetral deleted the fix/playground-text-format-toolbar branch September 29, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants