Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LinkNode.importDOM should support all node content #5010

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: LinkNode.importDOM should support all node content #5010

merged 1 commit into from
Sep 18, 2023

Conversation

k-rajat19
Copy link
Contributor

fix #4533

@vercel
Copy link

vercel bot commented Sep 16, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 4:56pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2023 4:56pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 16, 2023
zurfyx
zurfyx approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! While there might false positives (i.e. empty Text nodes), I think that's a reasonable approach and we can iterate on this later when we encounter them

@zurfyx zurfyx merged commit ad18d11 into facebook:main Sep 18, 2023
37 of 43 checks passed
@k-rajat19 k-rajat19 deleted the 4533 branch September 18, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: LinkNode.importDOM doesn't support image content
3 participants
@k-rajat19 @zurfyx @facebook-github-bot