Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Playground): CMD +K improvements #5013

Merged
merged 5 commits into from
Sep 22, 2023
Merged

fix(Playground): CMD +K improvements #5013

merged 5 commits into from
Sep 22, 2023

Conversation

k-rajat19
Copy link
Contributor

improved UX :
CMD +K on a link prompts users to edit it and on a non-link takes them directly to edit it.
resolves #4439

@vercel
Copy link

vercel bot commented Sep 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 7:21pm
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2023 7:21pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 17, 2023
@k-rajat19 k-rajat19 marked this pull request as ready for review September 17, 2023 23:03
zurfyx
zurfyx requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The way we envisioned this to work in #4439 is to have CMD + K showing the floating menu, then focusing the link input so that you're able to type the link right away like GDocs or Microsoft Word where you don't have to lift your hands from the keyboard. Would you mind iterating on this?

@k-rajat19
Copy link
Contributor Author

Thanks for the PR! The way we envisioned this to work in #4439 is to have CMD + K showing the floating menu, then focusing the link input so that you're able to type the link right away like GDocs or Microsoft Word where you don't have to lift your hands from the keyboard. Would you mind iterating on this?

yup that makes sense

zurfyx
zurfyx approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@zurfyx zurfyx merged commit f7603cf into facebook:main Sep 22, 2023
41 of 43 checks passed
@k-rajat19 k-rajat19 deleted the 4439 branch September 23, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Playground CMD + K improvements
3 participants
@k-rajat19 @zurfyx @facebook-github-bot