Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ToolbarPlugin paste error with start, end format #5019

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

khsily
Copy link
Contributor

@khsily khsily commented Sep 19, 2023

2023-09-19.1.57.16.mov

This error was made in PR #4904, which caused an 'Uncaught TypeError: Cannot read properties of undefined (reading 'name')' error due to missing format types (start and end).

This PR will add start, end format options to alignment dropdown.
스크린샷 2023-09-19 오후 3 16 57

@vercel
Copy link

vercel bot commented Sep 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 6:16am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2023 6:16am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2023
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM!

@zurfyx zurfyx merged commit 0e5671a into facebook:main Sep 28, 2023
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants