Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event handler removal in useDynamicPositioning, remove dupe code #5024

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Sep 20, 2023

If a handler was added as capturing, it must be removed as such too.

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lexical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 11:36am
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 11:36am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 20, 2023
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@zurfyx zurfyx merged commit 45557a9 into facebook:main Sep 20, 2023
39 of 43 checks passed
@thorn0 thorn0 deleted the useDynamicPositioning branch September 20, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants