MaxLength handle empty ElementNode #5029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zurfyx
requested review from
fantactuka,
acywatson and
thegreatercurve
as code owners
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
fantactuka
approved these changes
Sep 27, 2023
Comment on lines
176
to
177
| const lastDescendant: null | LexicalNode = | ||
| currentNode.getLastDescendant(); |
There was a problem hiding this comment.
nit
Suggested change
| const lastDescendant: null | LexicalNode = | |
| currentNode.getLastDescendant(); | |
| const lastDescendant = currentNode.getLastDescendant<LexicalNode>(); |
There was a problem hiding this comment.
Added the second part, TS is asking me to keep the type based on the assignation afterwards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iteration on #5020 to handle any empty ElementNode anywhere on the content