Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integrity #5068

Merged
merged 2 commits into from
Sep 29, 2023
Merged

Fix integrity #5068

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38e52fc
fix prettier
zurfyx Sep 29, 2023
02f329e
another
zurfyx Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/lexical-react/src/LexicalTypeaheadMenuPlugin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,11 @@ function getTextUpToAnchor(selection: RangeSelection): string | null {
return anchorNode.getTextContent().slice(0, anchorOffset);
}

function tryToPositionRange(leadOffset: number, range: Range, editorWindow: Window): boolean {
function tryToPositionRange(
leadOffset: number,
range: Range,
editorWindow: Window,
): boolean {
const domSelection = editorWindow.getSelection();
if (domSelection === null || !domSelection.isCollapsed) {
return false;
Expand Down Expand Up @@ -236,7 +240,7 @@ export function LexicalTypeaheadMenuPlugin<TOption extends MenuOption>({
useEffect(() => {
const updateListener = () => {
editor.getEditorState().read(() => {
const editorWindow = editor._window ?? window;
const editorWindow = editor._window || window;
const range = editorWindow.document.createRange();
const selection = $getSelection();
const text = getQueryTextForSearch(editor);
Expand All @@ -258,7 +262,11 @@ export function LexicalTypeaheadMenuPlugin<TOption extends MenuOption>({
match !== null &&
!isSelectionOnEntityBoundary(editor, match.leadOffset)
) {
const isRangePositioned = tryToPositionRange(match.leadOffset, range, editorWindow);
const isRangePositioned = tryToPositionRange(
match.leadOffset,
range,
editorWindow,
);
if (isRangePositioned !== null) {
startTransition(() =>
openTypeahead({
Expand Down
Loading